Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exposes params.statsFor and params.profile.metadataSource in LensConfig #686

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

cesarenaldi
Copy link
Member

No description provided.

@cesarenaldi cesarenaldi requested a review from krzysu November 9, 2023 12:49
Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 8611ee2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@lens-protocol/api-bindings Minor
@lens-protocol/react Minor
@lens-protocol/react-native Minor
@lens-protocol/react-web Minor
@lens-protocol/wagmi Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

height bot commented Nov 9, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-17455" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Jan 24, 2024 10:14am

---
"@lens-protocol/api-bindings": minor
"@lens-protocol/react": minor
"@lens-protocol/react-web": minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add react-native now too

@@ -46,8 +46,6 @@ export type LensConfig = {
storage?: IStorageProvider | IObservableStorageProvider;
/**
* The common query params allows you customize some aspect of the returned data.
*
* If not provided {@link defaultQueryParams} will be used instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall this be replaced with as in the react package

* @defaultValue see individual fields of {@link QueryParams}

Copy link
Contributor

@krzysu krzysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, LGTM 👍

@cesarenaldi cesarenaldi merged commit bb9a8dd into develop Jan 24, 2024
6 checks passed
@cesarenaldi cesarenaldi deleted the T-17455/fix-missing-common-query-params branch January 24, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants